----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14383/#review27167 -----------------------------------------------------------
src/master/registrar.hpp <https://reviews.apache.org/r/14383/#comment52853> Comments? src/master/registrar.cpp <https://reviews.apache.org/r/14383/#comment52854> Why not just use the process name space? src/master/registrar.cpp <https://reviews.apache.org/r/14383/#comment52855> Why is this templated? src/master/registrar.cpp <https://reviews.apache.org/r/14383/#comment52857> Why do we need an "id" here? Can't we grab it from "info" ? src/master/registrar.cpp <https://reviews.apache.org/r/14383/#comment52860> IIRC, the whole conditional operator stmt has to be wrapped in parentheses for it to output correctly. src/master/registrar.cpp <https://reviews.apache.org/r/14383/#comment52861> Why this pattern instead of doing onAny() and checking the future as we did in most other places? src/tests/registrar_tests.cpp <https://reviews.apache.org/r/14383/#comment52862> How about subclassing TemporaryDirectoryTest? - Vinod Kone On Sept. 28, 2013, 12:32 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14383/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2013, 12:32 a.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > See summary > > > Diffs > ----- > > src/Makefile.am ee336130ad93d8b524c841f75be36f00d4a2b147 > src/master/registrar.hpp PRE-CREATION > src/master/registrar.cpp PRE-CREATION > src/master/registry.proto 877bfa1465371f035f5d31606554415146d0c307 > src/tests/registrar_tests.cpp PRE-CREATION > src/tests/state_tests.cpp f39dee549ccd959f451bdfedba74837934376443 > > Diff: https://reviews.apache.org/r/14383/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
