> On Oct. 14, 2013, 6:30 p.m., Ben Mahler wrote: > > Awesome, love the batching stuff you added here! > > > > I added comments, some of which I will need fixed to integrate the > > Registrar into the Master. However, I'm giving you a ship it regardless > > depending on whether you would like to commit and leave the comments for me > > or make adjustments in this review.
I've committed this for you as discussed and I'll take up the comments in a subsequent review, can you mark as submitted? - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14383/#review26915 ----------------------------------------------------------- On Sept. 28, 2013, 12:32 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14383/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2013, 12:32 a.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > See summary > > > Diffs > ----- > > src/Makefile.am ee336130ad93d8b524c841f75be36f00d4a2b147 > src/master/registrar.hpp PRE-CREATION > src/master/registrar.cpp PRE-CREATION > src/master/registry.proto 877bfa1465371f035f5d31606554415146d0c307 > src/tests/registrar_tests.cpp PRE-CREATION > src/tests/state_tests.cpp f39dee549ccd959f451bdfedba74837934376443 > > Diff: https://reviews.apache.org/r/14383/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
