----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14800/#review27268 -----------------------------------------------------------
src/logging/logging.cpp <https://reviews.apache.org/r/14800/#comment53116> Awesome! Thanks! src/logging/logging.cpp <https://reviews.apache.org/r/14800/#comment53117> I think we want to add an else if which turns logging to stderr back off: if (!flags.quiet) { FLAGS_stderrthreshold = 0; // INFO. } else { FLAGS_logtostderr = false; } Otherwise, if someone specifies 'quiet' they'll still get logging to stderr. Make sense? - Benjamin Hindman On Oct. 21, 2013, 10:14 p.m., Yuval Pavel Zholkover wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14800/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2013, 10:14 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > The current intialization of glog creates log files in /tmp even when the > log_dir command argument is not passed. > Setting FLAGS_logtostderr to true disables all log file creation/writes. > > > Diffs > ----- > > src/logging/logging.cpp 850fb3c6f30afb0cb6a1f3a4a49abb87413cfb1d > > Diff: https://reviews.apache.org/r/14800/diff/ > > > Testing > ------- > > manual - during make check /tmp gets filled with glog logs (timestamped and > symlinked) > the patch fixes it > > > Thanks, > > Yuval Pavel Zholkover > >
