-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14800/
-----------------------------------------------------------
(Updated Oct. 22, 2013, 8:28 a.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
Changes
-------
I've updated the patch unfortunately, flags.quiet will not work when log_dir is
not set.
It looks like a bug in glog void LogMessage::SendToLog()
if (FLAGS_logtostderr || !IsGoogleLoggingInitialized()) {
ColoredWriteToStderr(data_->severity_,
data_->message_text_, data_->num_chars_to_log_);
ColoredWriteToStderr does not respect the severity threshold, it should have
been
if (FLAGS_logtostderr || !IsGoogleLoggingInitialized()) {
LogDestination::MaybeLogToStderr(data_->severity_, data_->message_text_,
data_->num_chars_to_log_);
Repository: mesos-git
Description
-------
The current intialization of glog creates log files in /tmp even when the
log_dir command argument is not passed.
Setting FLAGS_logtostderr to true disables all log file creation/writes.
Diffs (updated)
-----
src/logging/logging.cpp 850fb3c
Diff: https://reviews.apache.org/r/14800/diff/
Testing
-------
manual - during make check /tmp gets filled with glog logs (timestamped and
symlinked)
the patch fixes it
Thanks,
Yuval Pavel Zholkover
