----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11108/ -----------------------------------------------------------
(Updated Oct. 22, 2013, 7:04 p.m.) Review request for mesos and Benjamin Hindman. Changes ------- I can't update the diff for this: brenden@airbob ~/dev/mesos $ git cherry-pick f7f03b4a7adbe8cff28459076abc03ca552d0bf4 [am 9483529] Simplified os::hostname() in libstout. 1 file changed, 2 insertions(+), 31 deletions(-) brenden@airbob ~/dev/mesos $ ./support/post-reviews.py --target-groups=mesos --guess-fields Running post-review across all of ... 948352938d3c25f346a78fe042ab56df12373cc5 - (HEAD, am) Simplified os::hostname() in libstout. (2 seconds ago) Updating diff of: 948352938d3c25f346a78fe042ab56df12373cc5 - (HEAD, am) Simplified os::hostname() in libstout. (2 seconds ago) ... with parent diff created from: Press enter to continue or 'Ctrl-C' to skip. Failed to execute: 'post-review --review-request-id=11108 --repository-url=git://git.apache.org/mesos.git --tracking-branch=master --revision-range=master:948352938d3c25f346a78fe042ab56df12373cc5 --target-groups=mesos --guess-fields': Error uploading diff The generated diff file was empty. This usually means no files were modified in this change. Try running with --output-diff and --debug for more information. Your review request still exists, but the diff is not attached. brenden@airbob ~/dev/mesos $ The code is available here though: https://github.com/airbnb/mesos/commit/f7f03b4a7adbe8cff28459076abc03ca552d0bf4 Summary (updated) ----------------- Simplified os::hostname() in libstout. Repository: mesos Description (updated) ------- Simplified os::hostname() in libstout. Review: https://reviews.apache.org/r/11108 Diffs ----- 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 1b3fb47d7567b5467fef2a2bb15d5c4a2ea42aa5 Diff: https://reviews.apache.org/r/11108/diff/ Testing ------- Used in production at airbnb. make -j10 check && cd hadoop && make hadoop-2.0.0-mr1-cdh4.2.1 && make hadoop-0.20.205.0 && make hadoop-0.20.2-cdh3u3 Thanks, Brenden Matthews
