----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11108/#review27330 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp <https://reviews.apache.org/r/11108/#comment53158> This code was trying to get the hostname as described here: http://stackoverflow.com/questions/504810/how-do-i-find-the-current-machines-full-hostname-in-c-hostname-and-domain-info/505546#505546. IIUC the double lookup enables us to map a potential 'localhost' (returned from gethostname) into a 'foo.bar.baz'. What seemed to fail for you? - Benjamin Hindman On Oct. 22, 2013, 7:04 p.m., Brenden Matthews wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11108/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2013, 7:04 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos > > > Description > ------- > > Simplified os::hostname() in libstout. > > Review: https://reviews.apache.org/r/11108 > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 1b3fb47d7567b5467fef2a2bb15d5c4a2ea42aa5 > > Diff: https://reviews.apache.org/r/11108/diff/ > > > Testing > ------- > > Used in production at airbnb. > > make -j10 check && cd hadoop && make hadoop-2.0.0-mr1-cdh4.2.1 && make > hadoop-0.20.205.0 && make hadoop-0.20.2-cdh3u3 > > > Thanks, > > Brenden Matthews > >
