----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14815/#review27510 -----------------------------------------------------------
Ship it! src/hdfs/hdfs.hpp <https://reviews.apache.org/r/14815/#comment53446> Doesn't look like you are using 'output'? src/hdfs/hdfs.hpp <https://reviews.apache.org/r/14815/#comment53447> Why do this instead of returning an error when exit status is non-zero like you do for other commands below? Also lets just have thing function return Try<Nothing> instead of Try<bool> ? - Vinod Kone On Oct. 23, 2013, 6:58 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14815/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2013, 6:58 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/Makefile.am a2d82425f74dcaf3adf28ae8184fff53b3c34ceb > src/hdfs/hdfs.hpp PRE-CREATION > src/launcher/launcher.cpp bc39054141cd9451f3ff19e57f7b89a62b1de7fd > > Diff: https://reviews.apache.org/r/14815/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
