> On Oct. 25, 2013, 5:17 a.m., Vinod Kone wrote: > >
Thanks for the review! > On Oct. 25, 2013, 5:17 a.m., Vinod Kone wrote: > > src/hdfs/hdfs.hpp, lines 55-56 > > <https://reviews.apache.org/r/14815/diff/2/?file=369926#file369926line55> > > > > Doesn't look like you are using 'output'? Thanks! > On Oct. 25, 2013, 5:17 a.m., Vinod Kone wrote: > > src/hdfs/hdfs.hpp, line 62 > > <https://reviews.apache.org/r/14815/diff/2/?file=369926#file369926line62> > > > > Why do this instead of returning an error when exit status is non-zero > > like you do for other commands below? > > > > Also lets just have thing function return Try<Nothing> instead of > > Try<bool> ? This is returning whether or not the path exists in HDFS so bool (true yes, false no) is needed as well as Try to determine if there was an error trying to get this information. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14815/#review27510 ----------------------------------------------------------- On Oct. 23, 2013, 6:58 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14815/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2013, 6:58 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/Makefile.am a2d82425f74dcaf3adf28ae8184fff53b3c34ceb > src/hdfs/hdfs.hpp PRE-CREATION > src/launcher/launcher.cpp bc39054141cd9451f3ff19e57f7b89a62b1de7fd > > Diff: https://reviews.apache.org/r/14815/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
