----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14940/#review27562 -----------------------------------------------------------
Nice to see this! But my concern is that this patch will soon be no longer relevant since we're looking to move away from using github for rendering markdown. Assuming that my existing review for updating the documentation markdown will be accepted, we will be able to render these files directly within the mesos.apache.org website instead of sending folks to github. This will help with our overall SEO and make things less confusing (once source of truth vs two). - Dave Lester On Oct. 25, 2013, 11:47 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14940/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2013, 11:47 p.m.) > > > Review request for mesos and BenjaminVW BenjaminVW. > > > Repository: mesos-git > > > Description > ------- > > Using api.github.com for mark-down rendering limits off-line use and cause > trouble with help is excessively used on a shared IP due to api quota rules. > > This patch includes Christopher Jeffrey's Marked mark-down compiler > (https://github.com/chjj/marked) and replaces the github api call. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/help.hpp 65b0590 > src/Makefile.am a2d8242 > src/webui/master/static/js/marked.js PRE-CREATION > > Diff: https://reviews.apache.org/r/14940/diff/ > > > Testing > ------- > > make check > > And functional testing of /help endpoints. > > > Thanks, > > Niklas Nielsen > >
