> On Nov. 1, 2013, 5:42 p.m., Ross Allen wrote: > > 3rdparty/libprocess/include/process/help.hpp, line 246 > > <https://reviews.apache.org/r/14940/diff/3/?file=375921#file375921line246> > > > > Since jQuery is no longer removed, can you remove this <script> tag and > > the variable assignment above?
Whoops, can't type. Since jQuery is no longer used* - Ross ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14940/#review28023 ----------------------------------------------------------- On Nov. 1, 2013, 12:04 a.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14940/ > ----------------------------------------------------------- > > (Updated Nov. 1, 2013, 12:04 a.m.) > > > Review request for mesos and BenjaminVW BenjaminVW. > > > Repository: mesos-git > > > Description > ------- > > Using api.github.com for mark-down rendering limits off-line use and cause > trouble with help is excessively used on a shared IP due to api quota rules. > > This patch includes Christopher Jeffrey's Marked mark-down compiler > (https://github.com/chjj/marked) and replaces the github api call. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/help.hpp 65b0590 > src/Makefile.am a11c76b > src/webui/master/static/js/marked.min.js PRE-CREATION > > Diff: https://reviews.apache.org/r/14940/diff/ > > > Testing > ------- > > make check > > And functional testing of /help endpoints. > > > Thanks, > > Niklas Nielsen > >
