> On Oct. 29, 2013, 10:16 p.m., Ben Mahler wrote: > > src/slave/cgroups_isolator.cpp, line 783 > > <https://reviews.apache.org/r/14825/diff/3/?file=372966#file372966line783> > > > > Thanks for clarifying! > > > > For posterity, can you add a little note in the code explaining why > > we're avoiding 'rss' from the memory.stat file?
There is a Jira where it is explained. Further the next change that adds additional statistics makes it clear what the rss field actually measures. - Eric ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14825/#review27737 ----------------------------------------------------------- On Oct. 29, 2013, 6:32 a.m., Eric Biederman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14825/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2013, 6:32 a.m.) > > > Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone. > > > Bugs: Mesos-758 > https://issues.apache.org/jira/browse/Mesos-758 > > > Repository: mesos-git > > > Description > ------- > > cgroup_isolator: Report the actual amount of memory used > > Report the number of bytes used by the memory cgroup, and stop > reporting memory with no file backed pages taken into account. > > > Diffs > ----- > > src/slave/cgroups_isolator.cpp fc36f1f > > Diff: https://reviews.apache.org/r/14825/diff/ > > > Testing > ------- > > Verified that memory.stat:rss is the wrong value. > Verified that memory.usage_in_bytes is the correct value. > > make check > > Verified the code is idiomatic and trivial. > > > > Thanks, > > Eric Biederman > >
