----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15710/#review29156 -----------------------------------------------------------
src/tests/master_contender_detector_tests.cpp <https://reviews.apache.org/r/15710/#comment56297> Looks good, we should consider creating a testing abstraction to make sure that our tests do not run forever: DO_FOR (Seconds(10)) { ... } - Ben Mahler On Nov. 20, 2013, 1:20 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15710/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2013, 1:20 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-823 > https://issues.apache.org/jira/browse/MESOS-823 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/master_contender_detector_tests.cpp > 5e4237454133edc155e74ffa04aec24ccd04c1b4 > > Diff: https://reviews.apache.org/r/15710/diff/ > > > Testing > ------- > > make check 100 iterations > > > Thanks, > > Jiang Yan Xu > >
