----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15710/#review29275 -----------------------------------------------------------
src/tests/master_contender_detector_tests.cpp <https://reviews.apache.org/r/15710/#comment56429> I don't know if I like this abstraction. How about using the AWAIT_ macro here? If that doesn't work with paused clocks we should fix that instead. - Vinod Kone On Nov. 21, 2013, 11:18 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15710/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2013, 11:18 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-823 > https://issues.apache.org/jira/browse/MESOS-823 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/master_contender_detector_tests.cpp > 5e4237454133edc155e74ffa04aec24ccd04c1b4 > src/tests/zookeeper_tests.cpp 0059438a26bfd03ee6da15029ca7a67674ea637e > > Diff: https://reviews.apache.org/r/15710/diff/ > > > Testing > ------- > > make check Linux (100 iterations) and OSX. > > > Thanks, > > Jiang Yan Xu > >
