Re: Review Request 15773: Fixed master to ignore messages from unregistered framework.

[Ben Mahler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15773/#review29329
-----------------------------------------------------------



src/master/master.cpp
<https://reviews.apache.org/r/15773/#comment56513>

    Quoting from might be nice since UPID() prints nothing. Ditto elsewhere in 
the added messages.



src/master/master.cpp
<https://reviews.apache.org/r/15773/#comment56514>

    Maybe it's time to update resourceRequest, launchTasks, reviveOffers to log 
on NULL? Placing the rejection cases first might be more consistent:
    
    Framework* framework = getFramework(frameworkId);
    
    if (framework == NULL) {
      LOG(WARNING) << ...;
      return;
    }
    
    if (framework->pid != from) {
      LOG(WARNING) << ...;
      return;
    }
    
    LOG(INFO) << "Requesting resources for framework " << frameworkId;
    allocator->resourcesRequested(frameworkId, requests);



src/master/master.cpp
<https://reviews.apache.org/r/15773/#comment56515>

    I like how this one rejects with return first :)



src/tests/fault_tolerance_tests.cpp
<https://reviews.apache.org/r/15773/#comment56516>

    Can you add the steps that this test takes in numerical order? Just so I 
know what this test is doing to make it easier to read :)


- Ben Mahler


On Nov. 22, 2013, 1:48 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15773/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2013, 1:48 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Bugs: MESOS-834
>     https://issues.apache.org/jira/browse/MESOS-834
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See bug for details.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp c86c1f1e7eb23c168bcd2e8ab0a0701c421fc59d 
>   src/master/master.cpp a08d01208ff7bbb878b2d50d8406efee4de86171 
>   src/tests/fault_tolerance_tests.cpp 
> 6cb5829119ed3e855740fb9331e4fb19c16d3629 
> 
> Diff: https://reviews.apache.org/r/15773/diff/
> 
> 
> Testing
> -------
> 
> make check (Linux and OSX)
> 
> sudo ./bin/mesos-tests.sh 
> --gtest_filter="*IgnoreKillTaskFromUnregisteredFramework*"  
> --gtest_repeat=1000 --gtest_break_on_failure
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>