> On Nov. 23, 2013, 2:53 a.m., Ben Mahler wrote: > > src/tests/fault_tolerance_tests.cpp, line 1384 > > <https://reviews.apache.org/r/15773/diff/1/?file=389617#file389617line1384> > > > > Can you add the steps that this test takes in numerical order? Just so > > I know what this test is doing to make it easier to read :)
I typically write the gist of the test on the top. The specific steps are written as comments inside the test. That way there is no repetition. Let me know if the comments outside/inside are not clear. > On Nov. 23, 2013, 2:53 a.m., Ben Mahler wrote: > > src/master/master.cpp, line 1077 > > <https://reviews.apache.org/r/15773/diff/1/?file=389616#file389616line1077> > > > > Maybe it's time to update resourceRequest, launchTasks, reviveOffers to > > log on NULL? Placing the rejection cases first might be more consistent: > > > > Framework* framework = getFramework(frameworkId); > > > > if (framework == NULL) { > > LOG(WARNING) << ...; > > return; > > } > > > > if (framework->pid != from) { > > LOG(WARNING) << ...; > > return; > > } > > > > LOG(INFO) << "Requesting resources for framework " << frameworkId; > > allocator->resourcesRequested(frameworkId, requests); done > On Nov. 23, 2013, 2:53 a.m., Ben Mahler wrote: > > src/master/master.cpp, line 774 > > <https://reviews.apache.org/r/15773/diff/1/?file=389616#file389616line774> > > > > Quoting from might be nice since UPID() prints nothing. Ditto elsewhere > > in the added messages. I don't think 'from' or 'framework->pid' would ever be nothing, but ok, I'll quote them. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15773/#review29329 ----------------------------------------------------------- On Nov. 22, 2013, 1:48 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15773/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2013, 1:48 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-834 > https://issues.apache.org/jira/browse/MESOS-834 > > > Repository: mesos-git > > > Description > ------- > > See bug for details. > > > Diffs > ----- > > src/master/master.hpp c86c1f1e7eb23c168bcd2e8ab0a0701c421fc59d > src/master/master.cpp a08d01208ff7bbb878b2d50d8406efee4de86171 > src/tests/fault_tolerance_tests.cpp > 6cb5829119ed3e855740fb9331e4fb19c16d3629 > > Diff: https://reviews.apache.org/r/15773/diff/ > > > Testing > ------- > > make check (Linux and OSX) > > sudo ./bin/mesos-tests.sh > --gtest_filter="*IgnoreKillTaskFromUnregisteredFramework*" > --gtest_repeat=1000 --gtest_break_on_failure > > > Thanks, > > Vinod Kone > >
