----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15288/#review29356 -----------------------------------------------------------
src/master/http.cpp <https://reviews.apache.org/r/15288/#comment56553> Maybe s/flagsObject/flags/ ? src/master/http.cpp <https://reviews.apache.org/r/15288/#comment56550> Any reason you can't do: foreachpair (const string& name, const Flag& flag, master.flags) { flag.stringifier(); } Note, this is when s/stringifier/stringify/ sounds so much better! ;) src/slave/http.cpp <https://reviews.apache.org/r/15288/#comment56551> Also foreachpair here? - Benjamin Hindman On Nov. 20, 2013, 9:27 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15288/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2013, 9:27 p.m.) > > > Review request for mesos, Benjamin Hindman and Ross Allen. > > > Repository: mesos-git > > > Description > ------- > > This patch adds flags field to master and slave state.json end-points which > expose all configuration flags as additional diagnostics. > > > Diffs > ----- > > src/master/http.cpp f2a535a > src/slave/http.cpp 62fbb37 > > Diff: https://reviews.apache.org/r/15288/diff/ > > > Testing > ------- > > Functional testing of endpoints. > > make check > > > Thanks, > > Niklas Nielsen > >
