> On Dec. 4, 2013, 7:56 p.m., Benjamin Hindman wrote: > > src/master/http.cpp, line 406 > > <https://reviews.apache.org/r/15288/diff/2/?file=391427#file391427line406> > > > > YOu don't need to take the address of master.flags now right?
Ah right - need to adjust this patch to the latest toString/stringify patch. I'll get that done today :) - Niklas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15288/#review29748 ----------------------------------------------------------- On Nov. 27, 2013, 4:40 a.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15288/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2013, 4:40 a.m.) > > > Review request for mesos, Benjamin Hindman and Ross Allen. > > > Repository: mesos-git > > > Description > ------- > > This patch adds flags field to master and slave state.json end-points which > expose all configuration flags as additional diagnostics. > > > Diffs > ----- > > src/master/http.cpp 218906a > src/slave/http.cpp fbc917b > > Diff: https://reviews.apache.org/r/15288/diff/ > > > Testing > ------- > > Functional testing of endpoints. > > make check > > > Thanks, > > Niklas Nielsen > >
