----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15868/#review29470 -----------------------------------------------------------
src/tests/master_contender_detector_tests.cpp <https://reviews.apache.org/r/15868/#comment56700> Do these need to be AWAITs? Looks like these are necessarily non-pending from the above loop. src/tests/master_contender_detector_tests.cpp <https://reviews.apache.org/r/15868/#comment56701> Can you add a note as to why you moved these below the Clock::resume? - Ben Mahler On Nov. 27, 2013, 1:37 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15868/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2013, 1:37 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-823 > https://issues.apache.org/jira/browse/MESOS-823 > > > Repository: mesos-git > > > Description > ------- > > The last fix still missed a pending variable... > > > Diffs > ----- > > src/tests/master_contender_detector_tests.cpp > 8947732648219b69fbfdedc0f838e50a0c1ab2ef > > Diff: https://reviews.apache.org/r/15868/diff/ > > > Testing > ------- > > make check > ZooKeeperMasterContenderDetectorTest.ContenderDetectorShutdownNetwork 300 > iterations. > > > Thanks, > > Jiang Yan Xu > >
