> On Nov. 27, 2013, 2:04 a.m., Ben Mahler wrote: > > src/tests/master_contender_detector_tests.cpp, lines 311-312 > > <https://reviews.apache.org/r/15868/diff/1/?file=391345#file391345line311> > > > > Do these need to be AWAITs? Looks like these are necessarily > > non-pending from the above loop.
That's true. I was merely look at the code base and picking up code snippets that seem conventional https://github.com/apache/mesos/blob/afc0855fe7a1587b34d2d6cfb2eaf69c907935f7/src/tests/slave_recovery_tests.cpp#L582 Yes AWAIT_READY is unnecessary here. I'll remove them (and we'll revise AWAIT_READY later) > On Nov. 27, 2013, 2:04 a.m., Ben Mahler wrote: > > src/tests/master_contender_detector_tests.cpp, lines 331-333 > > <https://reviews.apache.org/r/15868/diff/1/?file=391345#file391345line331> > > > > Can you add a note as to why you moved these below the Clock::resume? They don't need to be below resume and I was just trying to move things out of the paused-time zone as much as possible and wasn't expecting this move to add more delay. - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15868/#review29470 ----------------------------------------------------------- On Nov. 27, 2013, 1:37 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15868/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2013, 1:37 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-823 > https://issues.apache.org/jira/browse/MESOS-823 > > > Repository: mesos-git > > > Description > ------- > > The last fix still missed a pending variable... > > > Diffs > ----- > > src/tests/master_contender_detector_tests.cpp > 8947732648219b69fbfdedc0f838e50a0c1ab2ef > > Diff: https://reviews.apache.org/r/15868/diff/ > > > Testing > ------- > > make check > ZooKeeperMasterContenderDetectorTest.ContenderDetectorShutdownNetwork 300 > iterations. > > > Thanks, > > Jiang Yan Xu > >
