> On Nov. 25, 2013, 2:22 a.m., Benjamin Hindman wrote: > > I think moving the stringifier stuff to it's own file sounds good to me too > > (stout/include/stout/flags/stringifier.hpp).
Sounds good! Added stringier.hpp > On Nov. 25, 2013, 2:22 a.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp, line 22 > > <https://reviews.apache.org/r/15285/diff/1/?file=380108#file380108line22> > > > > s/toString/stringifier/ > > > > I would prefer s/toString/stringify/ but then we should probably do > > s/loader/load/ too (feel free)! How about if I follow up with a separate loader -> load patch? > On Nov. 25, 2013, 2:22 a.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/loader.hpp, line 145 > > <https://reviews.apache.org/r/15285/diff/1/?file=380110#file380110line145> > > > > How about making the names be consistent with the Loader names? > > > > Loader => Stringifier > > OptionLoader => OptionStringifier > > MemberLoader => MemberStringifier > > OptionMemberLoader => OptionMemberStringifier > > > > I'm not opposed to changing Loader names but I'd just like them to be > > consistent. ;) Changed the stringifier methods to what you suggested :) - Niklas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15285/#review29355 ----------------------------------------------------------- On Nov. 27, 2013, 3:54 a.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15285/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2013, 3:54 a.m.) > > > Review request for mesos, Benjamin Hindman and Ross Allen. > > > Repository: mesos-git > > > Description > ------- > > This patch adds a toString member function to the Flag structure which lets > us iterate and fetch flag values. > During flag initialization, the toString methods are closed over the flag > value and option references. > Flag values can't be closed over up front as flag values may be changed by > user code arbitrarily. > So toString takes in the owning flags instance as a FlagsBase pointer: > toString(FlagsBase*). > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp d31c984 > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp fcaa4e4 > > Diff: https://reviews.apache.org/r/15285/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Niklas Nielsen > >
