Thanks!
On Tue, Dec 10, 2013 at 12:30 PM, Niklas Nielsen <[email protected]> wrote: > > > > On Dec. 10, 2013, 7:36 p.m., Ben Mahler wrote: > > > Hey Nik, it appears this broke 'make distcheck' because the > stringifier file was not added to src/Makefile.am, can you send out a fix? > > Shoot - sorry about that. Yes - I'll get that in. > > > - Niklas > > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15285/#review30115 > ----------------------------------------------------------- > > > On Dec. 4, 2013, 8:18 p.m., Niklas Nielsen wrote: > > > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > https://reviews.apache.org/r/15285/ > > ----------------------------------------------------------- > > > > (Updated Dec. 4, 2013, 8:18 p.m.) > > > > > > Review request for mesos, Benjamin Hindman and Ross Allen. > > > > > > Repository: mesos-git > > > > > > Description > > ------- > > > > This patch adds a stringify member function to the Flag structure which > > lets us iterate and fetch flag values. During flag initialization, the > > toString methods are closed over the flag value and option references. > > Flag values can't be closed over up front as flag values may be changed > > by user code arbitrarily. So stringify takes in the owning flags > > instance as a FlagsBase pointer: stringify(FlagsBase*). > > > > > > Diffs > > ----- > > > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp d31c984 > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp > cfe996e > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/stringifier.hpp > PRE-CREATION > > 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 9af2da1 > > > > Diff: https://reviews.apache.org/r/15285/diff/ > > > > > > Testing > > ------- > > > > make check > > > > > > Thanks, > > > > Niklas Nielsen > > > > > >
