----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15862/#review29494 -----------------------------------------------------------
Great! Why is it that they have to provide both? bootstrap <https://reviews.apache.org/r/15862/#comment56792> Can you kill this newline? bootstrap <https://reviews.apache.org/r/15862/#comment56793> I think we've been line wrapping these kinds of messages at 70 characters, can you do the same here? bootstrap <https://reviews.apache.org/r/15862/#comment56794> kill the extra whitespace - Ben Mahler On Nov. 26, 2013, 9:30 p.m., Bernardo Gomez Palacio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15862/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2013, 9:30 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > [MESOS-849] > > Enable AUTOMAKE and ACLOCAL env variables for bootstrap. > > The bootstrap script now supports an environment variable that points to > the AUTOMAKE, as well as ACLOCAL, that you want to use for building Mesos. > It also validates that if you specify an env entry for AUTOMAKE you do > the same for ACLOCAL. > > [ticket: MESOS-849]: As a developer I should be able to set the AUTOMAKE > and ACLOCAL environment variables for autoconf to pickup when using the > bootstrap script. > > > Diffs > ----- > > bootstrap 9e6c959 > > Diff: https://reviews.apache.org/r/15862/diff/ > > > Testing > ------- > > Tested using OSX > > #Base Scenario: > ./bootstrap > > #Defining AUTOMAKE without ACLOCAL: > # Expectation: ERROR message should be displayed. > AUTOMAKE="$(which automake-1.12)" ./bootstrap > > #Defining AUTOMAKE and ACLOCAL: > AUTOMAKE="$(which automake-1.12)" ACLOCAL="$(which aclocal-1.12)" ./bootstrap > > > Thanks, > > Bernardo Gomez Palacio > >
