> On Dec. 2, 2013, 6:53 p.m., Ben Mahler wrote: > > bootstrap, lines 20-21 > > <https://reviews.apache.org/r/15862/diff/3/?file=391983#file391983line20> > > > > What does _p and _m mean? How about naming these 'present' and > > 'missing' instead?
Changed _p to _present and _m to _missing. > On Dec. 2, 2013, 6:53 p.m., Ben Mahler wrote: > > bootstrap, lines 13-16 > > <https://reviews.apache.org/r/15862/diff/3/?file=391983#file391983line13> > > > > Do we need cmd_version to be a function here? It looks like it's only > > used in one place? In general we avoid helper functions like this unless > > this is used in several places to get the command version. In-lined the call to cmd_version and removed the function. - Bernardo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15862/#review29609 ----------------------------------------------------------- On Nov. 28, 2013, 12:15 a.m., Bernardo Gomez Palacio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15862/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2013, 12:15 a.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > [MESOS-849] > > Enable AUTOMAKE and ACLOCAL env variables for bootstrap. > > The bootstrap script now supports an environment variable that points to > the AUTOMAKE, as well as ACLOCAL, that you want to use for building Mesos. > It also validates that if you specify an env entry for AUTOMAKE you do > the same for ACLOCAL. > > [ticket: MESOS-849]: As a developer I should be able to set the AUTOMAKE > and ACLOCAL environment variables for autoconf to pickup when using the > bootstrap script. > > > Diffs > ----- > > bootstrap 9e6c959 > > Diff: https://reviews.apache.org/r/15862/diff/ > > > Testing > ------- > > Tested using OSX > > #Base Scenario: > ./bootstrap > > #Defining AUTOMAKE without ACLOCAL: > # Expectation: ERROR message should be displayed. > AUTOMAKE="$(which automake-1.12)" ./bootstrap > > #Defining AUTOMAKE and ACLOCAL: > AUTOMAKE="$(which automake-1.12)" ACLOCAL="$(which aclocal-1.12)" ./bootstrap > > > Thanks, > > Bernardo Gomez Palacio > >
