-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16197/
-----------------------------------------------------------
(Updated Dec. 12, 2013, 6:39 a.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, and Jiang Yan Xu.
Changes
-------
A different style (I liked this better).
In fact, exposing WeakReference is not a bad idea because it cannot be used
until it is upgraded.
Bugs: MESOS-877
https://issues.apache.org/jira/browse/MESOS-877
Repository: mesos-git
Description
-------
See summary. The idea is to introduce a WeakReference for Future (basically a
wrapper for std::weak_ptr).
Also, added an 'upgrade' function in WeakReference which returns
Option<Future<T> >. (pretty similar to std::weak_ptr::lock).
I tested the new impl. with the replicated log which requires strict reference
counting and cannot tolerate a leak in Future. It passed. Of course, make check
passed as well.
Diffs (updated)
-----
3rdparty/libprocess/include/process/future.hpp e473b3d
Diff: https://reviews.apache.org/r/16197/diff/
Testing
-------
make check
Thanks,
Jie Yu
