----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16197/#review30275 -----------------------------------------------------------
Looks good. Please ping benh to take a look as well. 3rdparty/libprocess/include/process/future.hpp <https://reviews.apache.org/r/16197/#comment57964> two space indent - Ben Mahler On Dec. 12, 2013, 6:39 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16197/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2013, 6:39 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Jiang Yan Xu. > > > Bugs: MESOS-877 > https://issues.apache.org/jira/browse/MESOS-877 > > > Repository: mesos-git > > > Description > ------- > > See summary. The idea is to introduce a WeakReference for Future (basically a > wrapper for std::weak_ptr). > > Also, added an 'upgrade' function in WeakReference which returns > Option<Future<T> >. (pretty similar to std::weak_ptr::lock). > > I tested the new impl. with the replicated log which requires strict > reference counting and cannot tolerate a leak in Future. It passed. Of > course, make check passed as well. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/future.hpp e473b3d > > Diff: https://reviews.apache.org/r/16197/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
