----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16764/#review31510 -----------------------------------------------------------
3rdparty/libprocess/src/decoder.hpp <https://reviews.apache.org/r/16764/#comment60022> A random thought during my commute home, do you need to check the result of http_parser_parse_url before you attempt to check what fields it has set? Or are you guaranteed that if it "failed" none of the below if checks will get invoked? - Benjamin Hindman On Jan. 9, 2014, 10:10 p.m., Timothy St. Clair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16764/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2014, 10:10 p.m.) > > > Review request for mesos and Timothy St. Clair. > > > Bugs: MESOS-896 > https://issues.apache.org/jira/browse/MESOS-896 > > > Repository: mesos-git > > > Description > ------- > > Update to enable support for different versions of http_parser then what is > currently bundled in mesos. > > > Diffs > ----- > > 3rdparty/libprocess/src/decoder.hpp > 4c29229aabd11ac2a273238cb4f50b02b6d3d7a8 > > Diff: https://reviews.apache.org/r/16764/diff/ > > > Testing > ------- > > > Thanks, > > Timothy St. Clair > >
