----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16764/#review31707 -----------------------------------------------------------
Ship it! I've taken the liberty of making the small cleanups mentioned in this review to keep things moving. Thanks for getting this to us Tim! Looking forward to the next ones! 3rdparty/libprocess/src/decoder.hpp <https://reviews.apache.org/r/16764/#comment60446> Still some whitespace that needs to get killed (here and elsewhere). 3rdparty/libprocess/src/decoder.hpp <https://reviews.apache.org/r/16764/#comment60447> Spaces around the '+' operator please. 3rdparty/libprocess/src/decoder.hpp <https://reviews.apache.org/r/16764/#comment60448> If this stuff wraps, we indent +4 after opening parens on a newline. 3rdparty/libprocess/src/decoder.hpp <https://reviews.apache.org/r/16764/#comment60449> This closing brace doesn't appear to be properly indented. - Benjamin Hindman On Jan. 13, 2014, 10:13 p.m., Timothy St. Clair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16764/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2014, 10:13 p.m.) > > > Review request for mesos and Timothy St. Clair. > > > Bugs: MESOS-896 > https://issues.apache.org/jira/browse/MESOS-896 > > > Repository: mesos-git > > > Description > ------- > > Update to enable support for different versions of http_parser then what is > currently bundled in mesos. > > > Diffs > ----- > > 3rdparty/libprocess/src/decoder.hpp 4c29229 > > Diff: https://reviews.apache.org/r/16764/diff/ > > > Testing > ------- > > > Thanks, > > Timothy St. Clair > >
