----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16590/#review31768 -----------------------------------------------------------
Ship it! I prefer withdraw() to return Failure() instead of false when contend() hasn't been called, but I'll leave it up to you. src/tests/zookeeper_tests.cpp <https://reviews.apache.org/r/16590/#comment60493> s/results in 'false' return value/returns false/ src/zookeeper/contender.cpp <https://reviews.apache.org/r/16590/#comment60510> Pull them back to where they are used? src/zookeeper/contender.cpp <https://reviews.apache.org/r/16590/#comment60508> Mention that withdrawing will be set to false in cancel(). src/zookeeper/contender.cpp <https://reviews.apache.org/r/16590/#comment60509> new line - Vinod Kone On Jan. 3, 2014, 10:45 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16590/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2014, 10:45 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > This includes when: > - withdraw() is called before contend() > - withdraw() is called after contend() but before the contender learns that > it fails to obtain the candidacy > - withdraw() is called after the contender has learned that it had failed to > obtain the candidacy > > > Diffs > ----- > > src/tests/zookeeper_tests.cpp 94d324a355b4d2189c317d73df0a174ccc38a853 > src/zookeeper/contender.hpp f45c0dfee4d41e269996a94cfbed71e878c76b13 > src/zookeeper/contender.cpp e857afa033bcaef06e38da997bd0c947c6153b21 > > Diff: https://reviews.apache.org/r/16590/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > >
