> On Jan. 14, 2014, 12:22 p.m., Vinod Kone wrote: > > I prefer withdraw() to return Failure() instead of false when contend() > > hasn't been called, but I'll leave it up to you.
OK. I'll leave it to return `bool`. > On Jan. 14, 2014, 12:22 p.m., Vinod Kone wrote: > > src/zookeeper/contender.cpp, line 226 > > <https://reviews.apache.org/r/16590/diff/1/?file=413865#file413865line226> > > > > Mention that withdrawing will be set to false in cancel(). It is mentioned three lines below where 'withdrawing' is checked so I think it should be sufficiently clear. - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16590/#review31768 ----------------------------------------------------------- On Jan. 14, 2014, 4:51 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16590/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2014, 4:51 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-892 > https://issues.apache.org/jira/browse/MESOS-892 > > > Repository: mesos-git > > > Description > ------- > > This includes when: > - withdraw() is called before contend() > - withdraw() is called after contend() but before the contender learns that > it fails to obtain the candidacy > - withdraw() is called after the contender has learned that it had failed to > obtain the candidacy > > > Diffs > ----- > > src/tests/zookeeper_tests.cpp 94d324a355b4d2189c317d73df0a174ccc38a853 > src/zookeeper/contender.hpp f45c0dfee4d41e269996a94cfbed71e878c76b13 > src/zookeeper/contender.cpp e857afa033bcaef06e38da997bd0c947c6153b21 > > Diff: https://reviews.apache.org/r/16590/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > >
