----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16149/#review32450 -----------------------------------------------------------
Ship it! Cool! Some style knits and a question on error reporting :) src/Makefile.am <https://reviews.apache.org/r/16149/#comment61295> Can you align '\''s? Again, the tabstop is 8. src/Makefile.am <https://reviews.apache.org/r/16149/#comment61297> And here. src/slave/container/cgroups_launcher.hpp <https://reviews.apache.org/r/16149/#comment61307> Can hierarchy be made const? src/slave/container/cgroups_launcher.cpp <https://reviews.apache.org/r/16149/#comment61309> Can subsystem be made const? src/slave/container/cgroups_launcher.cpp <https://reviews.apache.org/r/16149/#comment61298> Should we do a more graceful exit? Like EXIT(1) << ... src/slave/container/cgroups_launcher.cpp <https://reviews.apache.org/r/16149/#comment61310> Again, any need for LOG(FATAL)? src/slave/container/cgroups_launcher.cpp <https://reviews.apache.org/r/16149/#comment61306> Again - any reason for LOG(FATAL) instead of EXIT(1)? src/slave/container/cgroups_launcher.cpp <https://reviews.apache.org/r/16149/#comment61303> What happens if cgroups::exists() fails? It looks like an already exist error message will be shown? I found a bit confusing when figuring out that cgroups was mounted elsewhere (/sys/fs/cgroup), but that might of course just be my setup. src/slave/container/cgroups_launcher.cpp <https://reviews.apache.org/r/16149/#comment61304> s/fark/fork/ src/slave/container/launcher.hpp <https://reviews.apache.org/r/16149/#comment61305> Can you make this const? - Niklas Nielsen On Jan. 21, 2014, 11:34 a.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16149/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2014, 11:34 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Chi Zhang, Niklas > Nielsen, samya, and Jason Dusek. > > > Repository: mesos-git > > > Description > ------- > > Launcher interface and MesosLauncher to support MesosContainerizers. > > Launchers handle the lifecycle of the executor process (and descendants). > > > Diffs > ----- > > src/Makefile.am cf0c8c66e8dd21c2f5a2da22e5d5adb056353454 > src/slave/container/cgroups_launcher.hpp PRE-CREATION > src/slave/container/cgroups_launcher.cpp PRE-CREATION > src/slave/container/launcher.hpp PRE-CREATION > src/slave/container/launcher.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/16149/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > >
