----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16149/#review32432 -----------------------------------------------------------
Ship it! Looks great! src/Makefile.am <https://reviews.apache.org/r/16149/#comment61260> Alpha order? Keep linux/* together, or does this need to be this way? src/slave/container/cgroups_launcher.hpp <https://reviews.apache.org/r/16149/#comment61758> __CGROUPS_LAUNCHER_HPP__ src/slave/container/cgroups_launcher.cpp <https://reviews.apache.org/r/16149/#comment61764> Why not assign "path::join(flags.cgroups_root, "test")" to a variable, if it's going to be used 3 times in this function? src/slave/container/launcher.hpp <https://reviews.apache.org/r/16149/#comment61759> __LAUNCHER_HPP__ src/slave/container/launcher.hpp <https://reviews.apache.org/r/16149/#comment61762> I usually like to give collections plural names, so a list<RunState> would be named "states" src/slave/container/launcher.hpp <https://reviews.apache.org/r/16149/#comment61760> "Launcher suitable for" (remove the extra "for") src/slave/container/launcher.cpp <https://reviews.apache.org/r/16149/#comment61763> Do you want to include messages for any of these ErrnoError()s? - Adam B On Jan. 21, 2014, 11:34 a.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16149/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2014, 11:34 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Chi Zhang, Niklas > Nielsen, samya, and Jason Dusek. > > > Repository: mesos-git > > > Description > ------- > > Launcher interface and MesosLauncher to support MesosContainerizers. > > Launchers handle the lifecycle of the executor process (and descendants). > > > Diffs > ----- > > src/Makefile.am cf0c8c66e8dd21c2f5a2da22e5d5adb056353454 > src/slave/container/cgroups_launcher.hpp PRE-CREATION > src/slave/container/cgroups_launcher.cpp PRE-CREATION > src/slave/container/launcher.hpp PRE-CREATION > src/slave/container/launcher.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/16149/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > >
