> On Jan. 22, 2014, 5:52 p.m., Benjamin Hindman wrote:
> > src/master/detector.cpp, line 326
> > <https://reviews.apache.org/r/17172/diff/1/?file=434508#file434508line326>
> >
> > I assumed that we would be getting back the "label" to distinguish what
> > type we have and how we can "parse" it.
>
> Jiang Yan Xu wrote:
> Perhaps
>
> if (membership.label.isSome() && membership.label.get() ==
> MASTER_INFO_LABEL) {
> // Parse as MasterInfo
> } else if (membership.label.isNone()) {
> // Parse as PID.
> } // Ignore it otherwise.
>
> If in the future we want to use other formats we can just introduce some
> other label and not be worrying about backwards compatibility.
SGTM, although, maybe pull the label out first?
Option<string> label = membership.label();
if (label.isSome() && label == MASTER_INFO_LABEL) {
...
} else {
...
}
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17172/#review32501
-----------------------------------------------------------
On Jan. 22, 2014, 4:18 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17172/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2014, 4:18 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Brenden Matthews, and
> Jiang Yan Xu.
>
>
> Bugs: MESOS-903
> https://issues.apache.org/jira/browse/MESOS-903
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
> This is part 2 for MESOS-903.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 655f86757487ddbe551fdcf53eb793e773ecdd34
> src/master/detector.cpp cf337cfa598f019275fb299d354b674361a4aa68
> src/zookeeper/detector.cpp 2759a2fd31a6037e4e08ce270d36703cf89f5c73
> src/zookeeper/group.hpp 354229fe4f32d0d284e07819e7235edbea105c66
>
> Diff: https://reviews.apache.org/r/17172/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
