-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17172/#review32571
-----------------------------------------------------------

Ship it!



src/zookeeper/group.cpp
<https://reviews.apache.org/r/17172/#comment61465>

    You could do 'label()' instead of 'label_' too.


- Benjamin Hindman


On Jan. 22, 2014, 10:19 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17172/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2014, 10:19 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Brenden Matthews, and 
> Jiang Yan Xu.
> 
> 
> Bugs: MESOS-903
>     https://issues.apache.org/jira/browse/MESOS-903
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> This is part 2 for MESOS-903.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 655f86757487ddbe551fdcf53eb793e773ecdd34 
>   src/master/constants.hpp 8498c9b4cf5db1f67e14554cb9916dcd3376932d 
>   src/master/constants.cpp 0b7c9f7851b7b4ddbef7ed7fb6a59396d2f6d193 
>   src/master/detector.cpp cf337cfa598f019275fb299d354b674361a4aa68 
>   src/zookeeper/detector.cpp 2759a2fd31a6037e4e08ce270d36703cf89f5c73 
>   src/zookeeper/group.hpp 354229fe4f32d0d284e07819e7235edbea105c66 
>   src/zookeeper/group.cpp e21dc6f76f71bfe70bd83fa14d760f28c2cfa3d9 
> 
> Diff: https://reviews.apache.org/r/17172/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Reply via email to