----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17343/#review32782 -----------------------------------------------------------
Ship it! src/log/coordinator.hpp <https://reviews.apache.org/r/17343/#comment61750> Please add some comments about when None() will be returned. src/log/coordinator.hpp <https://reviews.apache.org/r/17343/#comment61751> Ditto here. - Jie Yu On Jan. 25, 2014, 12:43 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17343/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2014, 12:43 a.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > See summary > > > Diffs > ----- > > src/log/coordinator.hpp 35b68e938c5f2ca76bbdf8dbb0184ef1686d94f1 > src/log/coordinator.cpp bc85e668a01d60077fdd954139d60edd295ad3b0 > src/log/log.cpp e83f822af86a2389e2b1abab9489713cb59838c2 > src/state/zookeeper.hpp d1d1fedf27987aeaf9fbdee678d3b3848d05620a > src/tests/log_tests.cpp e493af4f2f2435efe168d07acd267b61afd37fe4 > > Diff: https://reviews.apache.org/r/17343/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
