----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17343/#review36048 -----------------------------------------------------------
Ship it! src/log/coordinator.hpp <https://reviews.apache.org/r/17343/#comment66873> Can you add a comment about when 'None' is returned here? src/log/coordinator.hpp <https://reviews.apache.org/r/17343/#comment66874> Ditto here. src/tests/log_tests.cpp <https://reviews.apache.org/r/17343/#comment66875> AWAIT_READY uses a default of 10 Seconds, any reason for the explicit duration here? src/tests/log_tests.cpp <https://reviews.apache.org/r/17343/#comment66876> Ditto here and in the tests below. - Ben Mahler On Feb. 19, 2014, 8:02 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17343/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2014, 8:02 a.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > See summary > > > Diffs > ----- > > src/log/coordinator.hpp 35b68e938c5f2ca76bbdf8dbb0184ef1686d94f1 > src/log/coordinator.cpp daa1ca8e719798743e46cb1f7b3f1cdd569b5f6d > src/log/log.hpp 1f0b30ddf8709cf64db7989775c8b0e926af99b5 > src/log/log.cpp e83f822af86a2389e2b1abab9489713cb59838c2 > src/state/zookeeper.hpp d1d1fedf27987aeaf9fbdee678d3b3848d05620a > src/tests/log_tests.cpp 7e6dbdee0a9b316e49fda5fd36a9f76331265a24 > > Diff: https://reviews.apache.org/r/17343/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
