> On Jan. 23, 2014, 10:27 a.m., Jie Yu wrote: > > src/logging/logging.cpp, line 44 > > <https://reviews.apache.org/r/17221/diff/1/?file=436199#file436199line44> > > > > Is this standard? What if other library also defines this function? > > Jiang Yan Xu wrote: > It's done in a similar way in other projects. e.g. > http://code.ohloh.net/file?fid=wPA9ao4biWVJANXrmsFQlQEMRp4&cid=mp6xqxVCDek&s=__cxa_pure_virtual&pp=0&fp=305441&fd=fndef&ff=1&filterChecked=true&mp=0&ml=1&me=1&md=1#L72 > I couldn't find authoritative documentation about this but given the > method name is mangled I doubt we would inadvertently run into other > libraries which write/expect this function to behave much differently. > > Thought on how this can be written in a better way? > > Ben Mahler wrote: > I think Jie is concerned about other libraries also providing an > implementation in the same vein as we've done here. > > Digging around, it seems to be part of the C++ ABI: > http://libcxxabi.llvm.org/spec.html > http://refspecs.linuxbase.org/cxxabi-1.83.html#vcall > > I would be ok with adding this, if we can confirm it works against gcc > and clang, OS X and Linux.
Thanks for the links. I ran a test program [https://gist.github.com/xujyan/622425c6ac386cf2b08e] on gcc/clang + OSX/Linux and it seems to work on all of them. - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17221/#review32645 ----------------------------------------------------------- On Jan. 23, 2014, 10:18 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17221/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2014, 10:18 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-937 > https://issues.apache.org/jira/browse/MESOS-937 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/logging/logging.cpp 6e71e5e37083f7d550a316ccb77f8994871afe99 > > Diff: https://reviews.apache.org/r/17221/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > >
