----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17221/#review33156 -----------------------------------------------------------
Ship it! src/logging/logging.cpp <https://reviews.apache.org/r/17221/#comment62454> Perhaps capture some of our findings on this review in a comment w.r.t. ABI, gcc and clang. - Ben Mahler On Jan. 23, 2014, 6:18 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17221/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2014, 6:18 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-937 > https://issues.apache.org/jira/browse/MESOS-937 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/logging/logging.cpp 6e71e5e37083f7d550a316ccb77f8994871afe99 > > Diff: https://reviews.apache.org/r/17221/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > >
