-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17573/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Brenden Matthews, Niklas Nielsen,
and Jiang Yan Xu.
Bugs: MESOS-672
https://issues.apache.org/jira/browse/MESOS-672
Repository: mesos-git
Description
-------
This is part 3.
This changes the semantics of how the default hostname is calculated. When no
hostname flag is provided we utilize the libprocess ip to get the hostname
(net::getHostname()) instead of os::hostname(). I think this is more
appropriate.
Now when the user selects
--ip=127.0.0.1 , default hostname is "localhost" instead of the public
hostname of the machine.
--ip=public ip, default hostname is "public hostname"
doesn't specifically set ip, hostname is "public hostname"
Note that --hostname flag overrides the hostname.
Diffs
-----
src/master/master.cpp 77872ece66601043ddeb280cceba5a7676e8a6be
src/slave/slave.cpp a97b1d531d05e63e8ebaa474f526c110f5d573d4
Diff: https://reviews.apache.org/r/17573/diff/
Testing
-------
make check
Thanks,
Vinod Kone
