-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17573/
-----------------------------------------------------------
(Updated Feb. 11, 2014, 7:12 a.m.)
Review request for mesos, Benjamin Hindman, Brenden Matthews, Niklas Nielsen,
and Jiang Yan Xu.
Changes
-------
rebased. NNFR.
Bugs: MESOS-672
https://issues.apache.org/jira/browse/MESOS-672
Repository: mesos-git
Description
-------
This is part 3.
This changes the semantics of how the default hostname is calculated. When no
hostname flag is provided we utilize the libprocess ip to get the hostname
(net::getHostname()) instead of os::hostname(). I think this is more
appropriate.
Now when the user selects
--ip=127.0.0.1 , default hostname is "localhost" instead of the public
hostname of the machine.
--ip=public ip, default hostname is "public hostname"
doesn't specifically set ip, hostname is "public hostname"
Note that --hostname flag overrides the hostname.
Diffs (updated)
-----
src/master/master.cpp 4d9a9d15b38e021adc04c34b2e86734567bb957e
src/slave/slave.cpp 1c0502e4b88719f18ecb0caface17b8511e9257b
Diff: https://reviews.apache.org/r/17573/diff/
Testing
-------
make check
Thanks,
Vinod Kone
