----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17568/ -----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Jeff Currier. Bugs: https://issues.apache.org/jira/browse/MESOS-953 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-953 Repository: mesos-git Description ------- Change stout JSON::Value default to be JSON::Null The first type specified for the variant which is JSON::Value is the default. Currently that is JSON::String which in turn defaults to empty string. JSON::Null would be a more correct default value. This change moves JSON::Null to the front of the declaration so that it becomes the default and adds a unit test. Diffs ----- 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 3148a7873397f6b0b2ebdbff3b640535ccd12318 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 29ada8a4a0396f889eb2583c3b3ff622050125af Diff: https://reviews.apache.org/r/17568/diff/ Testing ------- make check added unit test Thanks, Charlie Carson
