> On Jan. 28, 2014, 1:46 a.m., Adam B wrote: > > src/slave/containerizer/isolators/cgroups/cpushare.hpp, line 90 > > <https://reviews.apache.org/r/16432/diff/4/?file=451180#file451180line90> > > > > Just because cgroups uses "cpuacct", does that mean we need to keep > > that archaic name? I think cpuAccountHierarchy would be easier to read. Or > > cpuShareHierarchy if you'd rather.
I'd prefer to keep it matching the cgroup it refers to for consistency but don't feel super strongly. Others? > On Jan. 28, 2014, 1:46 a.m., Adam B wrote: > > src/slave/containerizer/isolators/cgroups/cpushare.cpp, line 361 > > <https://reviews.apache.org/r/16432/diff/4/?file=451181#file451181line361> > > > > Newline at end of file Not required for cpp and not used for other files in codebase. > On Jan. 28, 2014, 1:46 a.m., Adam B wrote: > > src/slave/containerizer/isolators/cgroups/mem.cpp, line 420 > > <https://reviews.apache.org/r/16432/diff/4/?file=451183#file451183line420> > > > > What if read.isNone()? > > If you assign this to 'usage' above the read.isSome() check, you could > > use it in the numify call instead of calling trim(read.get()) again. Code removed. > On Jan. 28, 2014, 1:46 a.m., Adam B wrote: > > src/slave/containerizer/isolators/cgroups/mem.cpp, line 431 > > <https://reviews.apache.org/r/16432/diff/4/?file=451183#file451183line431> > > > > What if 'usage' wasn't able to be read above (isNone)? Code removed. - Ian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16432/#review32889 ----------------------------------------------------------- On Jan. 27, 2014, 3:03 a.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16432/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2014, 3:03 a.m.) > > > Review request for mesos, Benjamin Hindman, Chi Zhang, samya, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Forth part of isolation refactor - cgroup isolators > > CPU and Memory isolators using Linux cgroups. > > This code was written by Chi Zhang <[email protected]> and based on the > original cgroups_isolator. > > > Diffs > ----- > > src/Makefile.am cf0c8c66e8dd21c2f5a2da22e5d5adb056353454 > src/slave/containerizer/isolators/cgroups/cgroups.hpp PRE-CREATION > src/slave/containerizer/isolators/cgroups/cgroups.cpp PRE-CREATION > src/slave/containerizer/isolators/cgroups/cpushare.hpp PRE-CREATION > src/slave/containerizer/isolators/cgroups/cpushare.cpp PRE-CREATION > src/slave/containerizer/isolators/cgroups/mem.hpp PRE-CREATION > src/slave/containerizer/isolators/cgroups/mem.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/16432/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > >
