> On Jan. 28, 2014, 8:51 p.m., Vinod Kone wrote: > > src/slave/containerizer/isolators/cgroups/cgroups.cpp, line 121 > > <https://reviews.apache.org/r/16432/diff/4/?file=451179#file451179line121> > > > > +1 > > > > How about moving this file up to "containerizer/cgroups.cpp" so that it > > can be used by both launcher and isolators?
Will be fixed later. - Ian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16432/#review33029 ----------------------------------------------------------- On Feb. 6, 2014, 5:37 a.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16432/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2014, 5:37 a.m.) > > > Review request for mesos, Benjamin Hindman, Chi Zhang, samya, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Forth part of isolation refactor - cgroup isolators > > CPU and Memory isolators using Linux cgroups. > > This code was written by Chi Zhang <[email protected]> and based on the > original cgroups_isolator. > > > Diffs > ----- > > src/Makefile.am c30706846bca1fa3287291e39f46a23713ad1ba4 > src/slave/containerizer/isolators/cgroups/cgroups.hpp PRE-CREATION > src/slave/containerizer/isolators/cgroups/cgroups.cpp PRE-CREATION > src/slave/containerizer/isolators/cgroups/cpushare.hpp PRE-CREATION > src/slave/containerizer/isolators/cgroups/cpushare.cpp PRE-CREATION > src/slave/containerizer/isolators/cgroups/mem.hpp PRE-CREATION > src/slave/containerizer/isolators/cgroups/mem.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/16432/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > >
