----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17564/#review34056 -----------------------------------------------------------
Ship it! The skeleton looks good to me. I'm curious what the interplay between the RepairCoordinator and the Master is going to be and how/if that will influence future API considerations. For example, should the RepairCoordinator be an actor? Also, I like the name Autopilot, I think this is a fine foundation to build on though. src/master/master.hpp <https://reviews.apache.org/r/17564/#comment64045> s/ */* /g src/master/repair_coordinator.cpp <https://reviews.apache.org/r/17564/#comment64046> We are pretty consistent here and do: } // namespace master { } // namespace internal { } // namespace mesos { - Benjamin Hindman On Jan. 31, 2014, 12:18 a.m., Charlie Carson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17564/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2014, 12:18 a.m.) > > > Review request for mesos, Benjamin Hindman, Jeff Currier, and Vinod Kone. > > > Bugs: https://issues.apache.org/jira/browse/MESOS-957 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-957 > > > Repository: mesos-git > > > Description > ------- > > Introduce a repair coordinator class to master. > > Add a RepairCoordinator class to master. Currently it is just > a stub, but it will soon get wired up to the new observe end-point > in master and recieve slave state updates. From there, it will be > responsible for persisting the state and ultimately performing > repairs on unhealthy slaves. > > The RepairCoordinator has virtual methods and destructor so that > it can easily be mocked for testing. > > Updated the existing master constructor to take a RepairCoordinator* > and local/local.cpp, master/main.cpp, & tests/cluster.hpp to new > up a RepairCoordinator, pass it to master's constructor and delete > the RepairCoordinator when it's finished. > > > Diffs > ----- > > src/Makefile.am c30706846bca1fa3287291e39f46a23713ad1ba4 > src/local/local.cpp 83a7f913afb1441e9137c7fcec8fd81815714905 > src/master/main.cpp b1e45766281c5ea0b8a3cee89e390ea60a97c5e4 > src/master/master.hpp 7649737283f5f5d786ac40504e943a3be4c1d62b > src/master/master.cpp 77872ece66601043ddeb280cceba5a7676e8a6be > src/master/repair_coordinator.hpp PRE-CREATION > src/master/repair_coordinator.cpp PRE-CREATION > src/tests/cluster.hpp 065976c19170e995bd3766bcc7a9b0a244776108 > > Diff: https://reviews.apache.org/r/17564/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Charlie Carson > >
