----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17564/#review34577 -----------------------------------------------------------
src/master/repair_man.hpp <https://reviews.apache.org/r/17564/#comment64723> I like Vinod's suggestion of 'Repairer' since repairman is not gender neutral, and repairer describes the functionality more purely. Thoughts? - Ben Mahler On Feb. 15, 2014, 1:56 a.m., Charlie Carson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17564/ > ----------------------------------------------------------- > > (Updated Feb. 15, 2014, 1:56 a.m.) > > > Review request for mesos, Benjamin Hindman, Jeff Currier, and Vinod Kone. > > > Bugs: MESOS-957 > https://issues.apache.org/jira/browse/MESOS-957 > > > Repository: mesos-git > > > Description > ------- > > Introduce a RepairMan class to master. > > Add a RepairMan class to master. Currently it is just a stub, but it will > soon get wired up to the new observe end-point in master and recieve slave > state updates. From there, it will be responsible for persisting the > state > and ultimately performing repairs on unhealthy slaves. > > The RepairMan has virtual methods and destructor so that it can easily be > mocked for testing. > > Updated the existing master constructor to take a RepairMan* > and local/local.cpp, master/main.cpp, & tests/cluster.hpp to new > up a RepairMan, pass it to master's constructor and delete > the RepairMan when it's finished. > > > Diffs > ----- > > src/Makefile.am aa8bb2b492e4d37b14db294f48c074e631143b68 > src/local/local.cpp 51123911595a7a2ac48458707ded2835935cbcbc > src/master/main.cpp ab4846eaebc13fe619c335c7763ac0b711df3d47 > src/master/master.hpp 737bd8b5a1cd88a98a7f094795c50547079921ba > src/master/master.cpp a4e1b1f7327f01eb16f14c3fa08fc7a62048d36c > src/master/repair_man.hpp PRE-CREATION > src/master/repair_man.cpp PRE-CREATION > src/tests/cluster.hpp 5100959f5de1e8e93bfbdeba26c95a33fe59f7e1 > > Diff: https://reviews.apache.org/r/17564/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Charlie Carson > >
