----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18001/#review34306 -----------------------------------------------------------
Super cool - here is a few comments. Also, 'no testing'? :) 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp <https://reviews.apache.org/r/18001/#comment64338> Sorry for being pedantic, but we split libprocess, stout and Mesos patches into separate patches. Can you move this to another RR and make it a dependency for this one? 3rdparty/libprocess/src/config.hpp <https://reviews.apache.org/r/18001/#comment64342> What is the motivation for stripping these out? 3rdparty/libprocess/src/net.hpp <https://reviews.apache.org/r/18001/#comment64341> Shouldn't you be able to use disableSigPipe() here? - Niklas Nielsen On Feb. 12, 2014, 10:49 a.m., Nikita Vetoshkin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18001/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2014, 10:49 a.m.) > > > Review request for mesos. > > > Bugs: MESOS-912 > https://issues.apache.org/jira/browse/MESOS-912 > > > Repository: mesos-git > > > Description > ------- > > Following the discussion in JIRA - disable SIGPIPE on MacOS via setsockopt as > it doesn't support MSG_NOSIGNAL. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > bba6f43eaeba0238a5db6e388902d92eb18f14f5 > 3rdparty/libprocess/src/config.hpp cbaf41d81846c061107e06a8bde197d30f2e469c > 3rdparty/libprocess/src/net.hpp 2fdc62adc4295a7723da0162a60853bc64c7073c > 3rdparty/libprocess/src/process.cpp > 2e7764a8e0badec704b8610f3f72f0bd16cc9612 > > Diff: https://reviews.apache.org/r/18001/diff/ > > > Testing > ------- > > None. > > > Thanks, > > Nikita Vetoshkin > >
