----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18001/#review34305 -----------------------------------------------------------
Ship it! Looks good barring the cleanups. 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp <https://reviews.apache.org/r/18001/#comment64339> We use complete sentences with capitalization and punctuation! ;) 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp <https://reviews.apache.org/r/18001/#comment64337> We always use braces with our if statements. 3rdparty/libprocess/src/net.hpp <https://reviews.apache.org/r/18001/#comment64340> Oops, net.hpp is actually dead code! :( Don't worry about fixing this up, we should really be remvoing this from the repository. 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/18001/#comment64345> This is not as readable as before and there isn't much harm in defining MSG_NOSGINAL on OS X so I'd prefer to keep it as it was before. 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/18001/#comment64346> Please wrap this as: LOG(FATAL) << "Failed to link, disableSigPipe: " << disableSigPipe.error(); 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/18001/#comment64347> Wrap as above please! - Benjamin Hindman On Feb. 12, 2014, 6:49 p.m., Nikita Vetoshkin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18001/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2014, 6:49 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-912 > https://issues.apache.org/jira/browse/MESOS-912 > > > Repository: mesos-git > > > Description > ------- > > Following the discussion in JIRA - disable SIGPIPE on MacOS via setsockopt as > it doesn't support MSG_NOSIGNAL. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > bba6f43eaeba0238a5db6e388902d92eb18f14f5 > 3rdparty/libprocess/src/config.hpp cbaf41d81846c061107e06a8bde197d30f2e469c > 3rdparty/libprocess/src/net.hpp 2fdc62adc4295a7723da0162a60853bc64c7073c > 3rdparty/libprocess/src/process.cpp > 2e7764a8e0badec704b8610f3f72f0bd16cc9612 > > Diff: https://reviews.apache.org/r/18001/diff/ > > > Testing > ------- > > None. > > > Thanks, > > Nikita Vetoshkin > >
