----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17636/#review34372 -----------------------------------------------------------
bin/memcheck-mesos-local.sh.in <https://reviews.apache.org/r/17636/#comment64456> Adding --tool=memcheck would make it explicit, and open the door to defining other tools (ie, helgrind) for more testing. - Dominic Hamon On Feb. 13, 2014, 3:42 p.m., TILL TOENSHOFF wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17636/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2014, 3:42 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Niklas Nielsen, and > Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Adds valgrind runnables for executing memory / leak checks on mesos. > > > Diffs > ----- > > bin/memcheck-mesos-local.sh.in PRE-CREATION > bin/memcheck-mesos-master.sh.in PRE-CREATION > bin/memcheck-mesos-slave.sh.in PRE-CREATION > bin/memcheck-mesos-tests.sh.in PRE-CREATION > configure.ac 4f988a9 > > Diff: https://reviews.apache.org/r/17636/diff/ > > > Testing > ------- > > $ mkdir build && bootstrap && cd build && ../configure && make check > > $ build/bin/memcheck-mesos-tests.sh > > Output: > > [...] > [----------] Global test environment tear-down > [==========] 221 tests from 39 test cases ran. (99862 ms total) > [ PASSED ] 218 tests. > [ FAILED ] 3 tests, listed below: > [ FAILED ] AttributesTest.Parsing > [ FAILED ] ResourcesTest.Parsing > [ FAILED ] ResourcesTest.Resources > > 3 FAILED TESTS > YOU HAVE 2 DISABLED TESTS > > ==3061== > ==3061== HEAP SUMMARY: > ==3061== in use at exit: 1,582,309 bytes in 24,258 blocks > ==3061== total heap usage: 4,401,619 allocs, 4,377,361 frees, 990,983,846 > bytes allocated > ==3061== > ==3061== LEAK SUMMARY: > ==3061== definitely lost: 107,320 bytes in 662 blocks > ==3061== indirectly lost: 1,045,445 bytes in 16,342 blocks > ==3061== possibly lost: 166,492 bytes in 2,758 blocks > ==3061== still reachable: 263,052 bytes in 4,496 blocks > ==3061== suppressed: 0 bytes in 0 blocks > ==3061== Rerun with --leak-check=full to see details of leaked memory > ==3061== > ==3061== For counts of detected and suppressed errors, rerun with: -v > ==3061== Use --track-origins=yes to see where uninitialised values come from > ==3061== ERROR SUMMARY: 38038 errors from 172 contexts (suppressed: 2 from 2) > > > Thanks, > > TILL TOENSHOFF > >
