----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18090/#review34412 -----------------------------------------------------------
src/slave/containerizer/cgroups_launcher.cpp <https://reviews.apache.org/r/18090/#comment64502> Ditto here. src/slave/containerizer/launcher.cpp <https://reviews.apache.org/r/18090/#comment64501> Please don't return in the child. Can you use the same logical structure as subprocess.hpp? - Ben Mahler On Feb. 13, 2014, 7:38 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18090/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2014, 7:38 p.m.) > > > Review request for mesos, Benjamin Hindman, Niklas Nielsen, TILL TOENSHOFF, > and Vinod Kone. > > > Bugs: MESOS-1000 > https://issues.apache.org/jira/browse/MESOS-1000 > > > Repository: mesos-git > > > Description > ------- > > See summary. Renamed exited() to avoid clash with ProcessBase. > > Further refactor around the forked child code path will be done later. > > > Diffs > ----- > > src/slave/containerizer/cgroups_launcher.cpp > 0921d631df19cff61ffb95ba228f6750e8c0ddb2 > src/slave/containerizer/launcher.cpp > ddfa91cb3e57d73ac103b6e10e43db4051496de4 > src/slave/containerizer/mesos_containerizer.hpp > f302c34de6ee76762e7f2f855d55b72fd313e845 > src/slave/containerizer/mesos_containerizer.cpp > 04b9fa10b8dc112b9f89f1086005e971da5b2911 > > Diff: https://reviews.apache.org/r/18090/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > >
