> On Feb. 13, 2014, 8:15 p.m., Niklas Nielsen wrote: > > src/slave/containerizer/mesos_containerizer.cpp, lines 397-404 > > <https://reviews.apache.org/r/18090/diff/1/?file=484514#file484514line397> > > > > This defer still breaks on clang. The compiler output is pretty > > verbose, so created a gist with it: https://gist.github.com/nqn/8982945 > >
Which clang version are you using? I'm compiling ok using all the fixes I've posted. [1232][idownes:mesos]$ clang++ --version Apple LLVM version 5.0 (clang-500.2.79) (based on LLVM 3.3svn) Target: x86_64-apple-darwin12.5.0 Thread model: posix - Ian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18090/#review34414 ----------------------------------------------------------- On Feb. 13, 2014, 9:16 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18090/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2014, 9:16 p.m.) > > > Review request for mesos, Benjamin Hindman, Niklas Nielsen, TILL TOENSHOFF, > and Vinod Kone. > > > Bugs: MESOS-1000 > https://issues.apache.org/jira/browse/MESOS-1000 > > > Repository: mesos-git > > > Description > ------- > > See summary. Renamed exited() to avoid clash with ProcessBase. > > Further refactor around the forked child code path will be done later. > > > Diffs > ----- > > src/slave/containerizer/cgroups_launcher.cpp > 0921d631df19cff61ffb95ba228f6750e8c0ddb2 > src/slave/containerizer/launcher.cpp > ddfa91cb3e57d73ac103b6e10e43db4051496de4 > src/slave/containerizer/mesos_containerizer.hpp > f302c34de6ee76762e7f2f855d55b72fd313e845 > src/slave/containerizer/mesos_containerizer.cpp > 04b9fa10b8dc112b9f89f1086005e971da5b2911 > > Diff: https://reviews.apache.org/r/18090/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > >
