----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17341/#review34447 -----------------------------------------------------------
Ship it! Looks good, just wondering if we can use the new process::socket function to prevent SIGPIPE on OS X. 3rdparty/libprocess/src/http.cpp <https://reviews.apache.org/r/17341/#comment64561> Looks like we could add some includes here: #include <cstring> #include <iostream> #include <string> #include <process/future.hpp> #include <stout/lambda.hpp> #include <stout/nothing.hpp> #include <stout/option.hpp> #include <stout/os.hpp> #include <stout/try.hpp> 3rdparty/libprocess/src/http.cpp <https://reviews.apache.org/r/17341/#comment64560> Can this use the new socket creation function in socket.hpp? (This would prevent SIGPIPE on OS X). - Ben Mahler On Feb. 13, 2014, 10:58 p.m., Charlie Carson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17341/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2014, 10:58 p.m.) > > > Review request for mesos, Benjamin Hindman and Jie Yu. > > > Bugs: https://issues.apache.org/jira/browse/MESOS-936 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-936 > > > Repository: mesos-git > > > Description > ------- > > move process::http namespace into http.cpp > > This moves the code declared in the process::http namespace to > be in it's own file (http.cpp). It already had it's own header. > > SEE: https://issues.apache.org/jira/browse/MESOS-936 > > Review: https://reviews.apache.org/r/17341 > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am bcb78a45788fe93c520a787c2b614d49c354e633 > 3rdparty/libprocess/src/http.cpp PRE-CREATION > 3rdparty/libprocess/src/process.cpp > 2e7764a8e0badec704b8610f3f72f0bd16cc9612 > > Diff: https://reviews.apache.org/r/17341/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Charlie Carson > >
